fix python bindings shared library directory issue

[hongxuchen]

using data_files dict prefixed with SITE_PACKAGES = os.path.join(get_python_lib(), "keystone") is not portable. Regular setup configuration does not work, e.g., specifying package_data etc, since that only affects sdist.

The fix is a hack: customize install_lib to explicitly copy the file into keystone install dir.

This should fix #235 and #297 .

[hongxuchen]

Also a bit os.chdir(cur_dir) to ensure after cmake build it will return to root dir even there are exceptions (merely used for local setup try).

[aquynh]

cool, did you look at the setup code of Unicorn for reference?

[hongxuchen]

@aquynh I didn't. I was just trying keystone and met the issue on my machine and didn't read your comment #297 carefully. Unicorn seems different as it also needs to include headers, etc?

[aquynh]

the difference is not big. or you can look at the setup of Capstone, which works & proven.

by porting the setup.py of Capstone or Unicorn over, we can fix other minor issues. please let me know if you can work on this, thanks.

[hongxuchen]

Okay, I will take a look at that and hopefully there is a general and consistent solution.

[hongxuchen]

Hi @aquynh , I modified both capstone and unicorn's setup files, and I think it is now consistent. It supports:

• sdist
• bdist (with wheel if possible)

lib and include are put inside the installed root directories respectively.

keystone's setup should be modified to fit for the requirement.

Please check whether you're comfortable with these changes.

setups.zip

[williballenthin]

@aquynh whats the status of this PR? will it be merged soon, or are you awaiting additional fixes?

[aquynh]

merged, thanks!