This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Ensure sauce connection is closed on errors #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webteckie
reviewed
Jan 7, 2017
| @@ -81,6 +82,7 @@ function startSauceConnect (done) { | |||
| } | |||
There was a problem hiding this comment.
Actually, I think execution will fall through here and hit the following code so you need to do else.
webteckie
reviewed
Jan 7, 2017
| callback && callback(err); | ||
| if (sauceConnectionRunning) { | ||
| console.log([moment().format('HH:mm:ss:SSS')] + ' e2e: something seems to have gone wrong, stopping sauce connect before travis shuts down'); | ||
| stopSauceConnect(callback && callback(err)); |
There was a problem hiding this comment.
This doesn't feel right. The callback will be evaluated and called here before stopSauceConnect is called.
There was a problem hiding this comment.
Yeah I wasn't sure here. What should it be?
There was a problem hiding this comment.
You need to pass in a function that itself calls the call back:
stopSauceConnect( function () {callback && callback(err)})
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @webteckie
I think this may (at least help) to solve some of those problems where travis doesn't close the sauce tunnel on error.
Even if not, I think this is something we should be doing now we're handling the connection manually. What do you think?