Permalink
Browse files

Add test to guidelines

We really need to improve test coverage. Let's make sure the test requirement is in the guidelines. =)
  • Loading branch information...
1 parent b9b2c7b commit 0aaa02690167a33294e4ee07f67e6cee13dfcf26 @ericelliott ericelliott committed Dec 4, 2015
Showing with 2 additions and 0 deletions.
  1. +2 −0 CONTRIBUTING.md
View
@@ -13,6 +13,7 @@ as a pull request - it helps core members review your concept and direction
early and is a good way to discuss what you're planning to do.
* If you open an issue and are interested in working on a fix, please let us
know. We'll help you get started, rather than adding it to the queue.
+* If the pull request fixes a bug, it should include tests that fail without the changes, and pass with them.
* Make sure you do not add regressions by running `npm test`. Please also
[follow our established coding conventions](https://github.com/keystonejs/keystone/wiki/Coding-Standards)
(with regards to formatting, etc)
@@ -22,6 +23,7 @@ but please ensure there are not more violations than before your changes.
* We have three translations so far,
please read our [Documentation Translation Guidelines](https://github.com/keystonejs/keystone/wiki/Documentation-Translation-Guidelines).
+
If you are working on the React Admin UI, you'll also need to know this:
* The Admin UI is generated with Browserify when Keystone starts. To enable

0 comments on commit 0aaa026

Please sign in to comment.