Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter and CRUD tests for AutoIncrement field #3415

Merged
merged 2 commits into from Aug 28, 2020

Conversation

@singhArmani
Copy link
Contributor

@singhArmani singhArmani commented Aug 18, 2020

  • Add a filter to accommodate adapter specific field API tests.
  • Update fields.test.js to insert items in an order as in array returned by initItems() function of the module.
@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Aug 18, 2020

🦋 Changeset is good to go

Latest commit: 5884503

We got this.

This PR includes changesets to release 2 packages
Name Type
@keystonejs/api-tests Patch
@keystonejs/fields-auto-increment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Loading

@request-info
Copy link

@request-info request-info bot commented Aug 18, 2020

It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue.

Loading

@singhArmani singhArmani force-pushed the add-filter-tests-autoincrement branch from 9c0ed65 to 7b85de7 Aug 18, 2020

describe('Fields', () => {
const testModules = globby.sync(
[`packages/**/src/**/test-fixtures.js`, `!packages/fields-auto-increment/src/test-fixtures.js`],
Copy link
Contributor

@timleslie timleslie Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like having package-specific code in this general file. Can we find a way to implement this logic in such a way that it becomes part of the test-fixtures.js configuration?

Loading

@singhArmani singhArmani force-pushed the add-filter-tests-autoincrement branch 2 times, most recently from 515a3b5 to d60c7b7 Aug 20, 2020
@singhArmani singhArmani force-pushed the add-filter-tests-autoincrement branch 3 times, most recently from 2a4d218 to 228a8aa Aug 20, 2020
@singhArmani singhArmani requested a review from timleslie Aug 20, 2020
@singhArmani singhArmani force-pushed the add-filter-tests-autoincrement branch 2 times, most recently from 9dde602 to 1898cad Aug 24, 2020
@singhArmani singhArmani force-pushed the add-filter-tests-autoincrement branch 4 times, most recently from 6f87bcb to 0026596 Aug 28, 2020
@singhArmani singhArmani force-pushed the add-filter-tests-autoincrement branch from 0026596 to 5884503 Aug 28, 2020
Copy link
Contributor

@timleslie timleslie left a comment

👍

Loading

@singhArmani singhArmani merged commit bbeb0f7 into master Aug 28, 2020
16 checks passed
Loading
@singhArmani singhArmani deleted the add-filter-tests-autoincrement branch Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants