Allow HTTP/2 with letsencrypt #3828

Merged
merged 2 commits into from Jan 10, 2017

Projects

None yet

2 participants

@wmertens
Contributor

For some reason, letsencrypt forces the NPNProtocols option, which inhibits spdy from offering HTTP/2.

@wmertens wmertens Allow HTTP/2 with letsencrypt
For some reason, `letsencrypt` forces the `NPNProtocols` option, which inhibits `spdy` from offering HTTP/2.
a951282
@wmertens wmertens requested a review from JedWatson Dec 29, 2016
@wmertens wmertens lint
d0e17fd
@JedWatson

Looks good to me. I feel like we should raise this on the letsencrypt repo though? Happy to merge but ideally this would be explained / fixed upstream. Let me know if you want to push the button.

@wmertens
Contributor

Good point. I'll push the button so it works, and I'll open an issue.

@wmertens wmertens merged commit b96b6fb into master Jan 10, 2017

3 checks passed

codeclimate/coverage 57.25%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@wmertens wmertens deleted the http2 branch Jan 10, 2017
@wmertens wmertens referenced this pull request in Daplie/localhost.daplie.com-certificates Jan 10, 2017
@coolaj86 coolaj86 fix NPNProtocols and SNICallback callback (previous commit) 0bcba93
@bassjacob bassjacob added a commit that referenced this pull request Jan 16, 2017
@wmertens @bassjacob wmertens + bassjacob Allow HTTP/2 with letsencrypt (#3828)
* Allow HTTP/2 with letsencrypt

For some reason, `letsencrypt` forces the `NPNProtocols` option, which inhibits `spdy` from offering HTTP/2.

* lint
eab2807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment