Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSS] Replace unique -> isUnique and required -> isRequired #548

Merged
merged 3 commits into from Dec 6, 2018

Conversation

@timleslie
Copy link
Contributor

timleslie commented Dec 6, 2018

This implements the changes discussed in #461. Having this tangible implementation might make it easier to decide whether this is what we want.

Having seen these changes I'm in favour of making the change. Not least of all because we have a function called unique() which returns the unique values from a list. Spelling the boolean flag isUnique makes it easier to search for the different cases.

Copy link
Contributor

jesstelford left a comment

Needs a changeset which does a major version bump!

Copy link
Contributor

jesstelford left a comment

As discussed offline; core needs to have a major version bump due to the change in API it exposes.

@mitchellhamilton

This comment has been minimized.

Copy link
Member

mitchellhamilton commented Dec 6, 2018

Shouldn't they be minor bumps since these packages are on 0.x and minors on 0.x can be breaking?

@timleslie

This comment has been minimized.

Copy link
Contributor Author

timleslie commented Dec 6, 2018

@mitchellhamilton Yeah, they probably could be minors but I think it's probably easier to move into a 1.x.x regime so that we can make full use of the semver levels.

@timleslie timleslie force-pushed the is-boolean branch from b265140 to 78fd955 Dec 6, 2018
@timleslie timleslie merged commit f587637 into master Dec 6, 2018
4 checks passed
4 checks passed
ci/circleci: integration_tests_accesscontrol Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_basic Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_login Your tests passed on CircleCI!
Details
ci/circleci: simple_tests Your tests passed on CircleCI!
Details
@timleslie timleslie deleted the is-boolean branch Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.