Skip to content

Fix list.ui.hide* functionality#9217

Merged
dcousens merged 2 commits intomainfrom
fix-hide-ui
Jul 17, 2024
Merged

Fix list.ui.hide* functionality#9217
dcousens merged 2 commits intomainfrom
fix-hide-ui

Conversation

@dcousens
Copy link
Copy Markdown
Member

@dcousens dcousens commented Jul 17, 2024

Resolves #9216
Thanks to @tv42 for reporting this and proposing a fix.

@dcousens dcousens self-assigned this Jul 17, 2024
@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit affda48:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens merged commit 5ee45ae into main Jul 17, 2024
@dcousens dcousens deleted the fix-hide-ui branch July 17, 2024 01:20
@dcousens
Copy link
Copy Markdown
Member Author

dcousens commented Jul 17, 2024

Arguably having ui.hideCreate and graphql.omit.create is silly.
As is, you can force ui.hideCreate: false and graphql.omit.create: true, and you'll have a broken create button in the admin.

Maybe the type should be graphql.omit.create: true | false | 'ui' or something.

Thoughts @tv42?

@dcousens dcousens mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui.hideCreate and ui.hideDelete don't work when graphql.omit.create and graphql.omit.delete are set

1 participant