Skip to content

Revert packages to use nominal package versions#9269

Merged
dcousens merged 7 commits into
mainfrom
no-catalog
Aug 7, 2024
Merged

Revert packages to use nominal package versions#9269
dcousens merged 7 commits into
mainfrom
no-catalog

Conversation

@dcousens

@dcousens dcousens commented Aug 7, 2024

Copy link
Copy Markdown
Member

Alternative to #9266
Reverting #9112 and other pull requests, and seeking an alternative strategy for working with workspace package versioning.

Comment thread .changeset/config.json
"linked": [],
"access": "public",
"privatePackages": {
"version": false

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stops examples/ from generating CHANGELOG.md and version bumps

"version": "0.0.1",
"version": null,
"private": true,
"author": "Dinesh Pandiyan <flexdinesh@gmail.com>",

@dcousens dcousens Aug 7, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flexdinesh 💛 but we don't add this field for any of the other examples, that is what git is for

@dcousens

dcousens commented Aug 7, 2024

Copy link
Copy Markdown
Member Author

@kennedybaird if you can follow up this work with a pull request that resolves the fixPrismaPath and bump the CodeSandbox configurations to use Node 20, that would be really appreciated.

I think this configuration works well with pnpm changeset version, which is what we are using for release; and keeps the maintenance about the same.

@codesandbox-ci

codesandbox-ci Bot commented Aug 7, 2024

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a082e0a:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens merged commit 27845c8 into main Aug 7, 2024
@dcousens dcousens deleted the no-catalog branch August 7, 2024 10:19
@dcousens dcousens mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant