Fix URL validation by preserving percent-encoded characters#9326
Merged
dcousens merged 2 commits intokeystonejs:mainfrom Sep 24, 2024
Merged
Fix URL validation by preserving percent-encoded characters#9326dcousens merged 2 commits intokeystonejs:mainfrom
dcousens merged 2 commits intokeystonejs:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1ef9264:
|
Member
|
@kidneyweakx can you please add a changeset? |
Contributor
Author
Added. |
dcousens
approved these changes
Sep 24, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue where the
@braintree/sanitize-urlpackage automatically decodes certain percent-encoded characters (e.g., %E5%BD%93%E5%89%8D into 当前). This causes the sanitized URL to differ from the original, which can result in false validation failures for URLs containing encoded Unicode characters.To resolve this:
This fix ensures that URLs with percent-encoded Unicode characters are considered valid if they match either the original or the encoded version of the sanitized URL.
Test Cases:
Before


After
Let me know if you need any further changes!