chore(lint): make eslint run, fix errors#9361
Merged
dcousens merged 6 commits intokeystonejs:mainfrom Oct 17, 2024
unrevised6419:fix/adjust-eslint-rules
Merged
chore(lint): make eslint run, fix errors#9361dcousens merged 6 commits intokeystonejs:mainfrom unrevised6419:fix/adjust-eslint-rules
dcousens merged 6 commits intokeystonejs:mainfrom
unrevised6419:fix/adjust-eslint-rules
Conversation
unrevised6419
commented
Oct 11, 2024
Comment on lines
-14
to
+17
| 'examples/extend-graphql-schema-nexus/nexus-types.ts' | ||
| 'examples/', |
Contributor
Author
There was a problem hiding this comment.
I decided to completely ignore examples, it may be a pain to maintain. I can revert if needed and adjust or ignore lines.
Member
There was a problem hiding this comment.
not ideal, but one step at a time
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 418b459:
|
dcousens
approved these changes
Oct 17, 2024
Member
|
Thanks for this @iamandrewluca! 💚 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only error left in 45 files is this one. Can we disable it, or maybe somehow fix them?! 🤔
Closes #9316
npm run lint ✖ 45 problems (45 errors, 0 warnings)