Skip to content

chore(lint): make eslint run, fix errors#9361

Merged
dcousens merged 6 commits intokeystonejs:mainfrom
unrevised6419:fix/adjust-eslint-rules
Oct 17, 2024
Merged

chore(lint): make eslint run, fix errors#9361
dcousens merged 6 commits intokeystonejs:mainfrom
unrevised6419:fix/adjust-eslint-rules

Conversation

@unrevised6419
Copy link
Copy Markdown
Contributor

@unrevised6419 unrevised6419 commented Oct 11, 2024

The only error left in 45 files is this one. Can we disable it, or maybe somehow fix them?! 🤔

error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

✖ 45 problems (45 errors, 0 warnings)

Closes #9316

npm run lint ✖ 45 problems (45 errors, 0 warnings)

/Users/iamandrewluca/Projects/github/fork-keystone/design-system/packages/icons/build-icons.js
  1:14  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  2:12  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  4:14  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  5:19  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  6:22  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  7:16  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/design-system/website/next.config.js
  2:26  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/packages/core/bin/cli.js
  3:1  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/packages/core/src/lib/telemetry.ts
  138:27  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/packages/core/src/scripts/dev.ts
  225:36  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/packages/core/src/scripts/esbuild.ts
  24:17  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/packages/core/src/scripts/start.ts
  27:24  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/packages/core/src/scripts/utils.ts
  14:12  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/packages/core/tests/telemetry.test.ts
  311:28  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  334:24  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/scripts/prepare-release.js
  1:23  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  2:41  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  3:37  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  4:21  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/tests/admin-ui-tests/utils.ts
  50:28  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/tests/api-tests/db-map.test.ts
  51:15  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/tests/api-tests/fields/crud.test.ts
  18:15  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/tests/api-tests/fields/required.test.ts
  19:15  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/tests/api-tests/fields/unique.test.ts
   16:15  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  141:15  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/tests/benchmarks/fixtures/create-related.js
  1:32  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  2:18  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  3:29  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  4:27  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  5:54  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/tests/benchmarks/fixtures/create.js
  1:18  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  2:18  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  3:29  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  4:27  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  5:54  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/tests/benchmarks/fixtures/index.js
  1:20  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  1:44  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  1:76  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/tests/benchmarks/fixtures/query.js
  1:32  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  2:18  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  3:29  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  4:27  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  5:54  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/tests/cli-tests/migrations.test.ts
  109:15  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/iamandrewluca/Projects/github/fork-keystone/tests/examples-smoke-tests/utils.ts
  24:28  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

✖ 45 problems (45 errors, 0 warnings)

Comment thread eslint.config.mjs
Comment on lines -14 to +17
'examples/extend-graphql-schema-nexus/nexus-types.ts'
'examples/',
Copy link
Copy Markdown
Contributor Author

@unrevised6419 unrevised6419 Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to completely ignore examples, it may be a pain to maintain. I can revert if needed and adjust or ignore lines.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not ideal, but one step at a time

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Oct 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 418b459:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens merged commit e987f2d into keystonejs:main Oct 17, 2024
@dcousens
Copy link
Copy Markdown
Member

Thanks for this @iamandrewluca! 💚

@unrevised6419 unrevised6419 deleted the fix/adjust-eslint-rules branch October 17, 2024 06:21
@dcousens dcousens mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running eslint fails with Could not find "member-delimiter-style"

2 participants