context.db should not omit types omitted from the GraphQL schema#9402
Merged
dcousens merged 3 commits intokeystonejs:mainfrom Feb 4, 2025
Merged
context.db should not omit types omitted from the GraphQL schema#9402dcousens merged 3 commits intokeystonejs:mainfrom
context.db should not omit types omitted from the GraphQL schema#9402dcousens merged 3 commits intokeystonejs:mainfrom
Conversation
conext.db should not omit types omitted from the GraphQL schema
conext.db should not omit types omitted from the GraphQL schemacontext.db should not omit types omitted from the GraphQL schema
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0f89bb9:
|
Contributor
Author
|
@dcousens for the record. The type error is not "the method is 'undefined'". I get this: |
0f89bb9 to
ce3f3d4
Compare
Co-authored-by: Emma Hamilton <git@emmas.town>
ce3f3d4 to
f2928cd
Compare
emmatown
added a commit
that referenced
this pull request
Feb 24, 2025
…9402) Co-authored-by: Emma Hamilton <git@emmas.town> Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keystone List documentation says:
.. but this none-the-less affects the types of
context.dbThe
.datatype indb.SomeList.createresults in anever, which is unnecessary.This pull request fixes that.