Permalink
Browse files

Drop Requires: line from fishsound.pc.in

This line is only needed if packages that build against libfishsound
needs access to the Cflags of the required packages. In this case, the
listed packages (vorbis, speex, flac) are precisely the packages that
libfishsound provide a wrapper API for, so apps compiling against
libfishsound really should not need their headers directly.

This was not a problem in 0.9.1, but in 1.0.0 the FLAC headers are
exported, and this include a really regrettably misnamed assert.h, which
shadows the system assert.h and causes compilation of sonic-visualiser
to fail.

I've tried removing the Requires: line and can report that it results in
a functioning sonic-visualiser build.

Reported-by: hircus
  • Loading branch information...
1 parent 74f09f0 commit 6815cab63df1a66f4d2b27c43632fe918857d1ce @kfish committed Jul 16, 2010
Showing with 0 additions and 1 deletion.
  1. +0 −1 fishsound.pc.in
View
@@ -5,7 +5,6 @@ includedir=@includedir@
Name: fishsound
Description: Encode and decode Vorbis, Speex, FLAC audio
-Requires: @fishsound_pkgdeps@
Version: @VERSION@
Libs: -L${libdir} -lfishsound
Libs.private: @VORBIS_LIBS@ @SPEEX_LIBS@ @FLAC_LIBS@

0 comments on commit 6815cab

Please sign in to comment.