Skip to content


Subversion checkout URL

You can clone with
Download ZIP
branch: master
Commits on Jul 16, 2010
  1. Drop Requires: line from

    This line is only needed if packages that build against libfishsound
    needs access to the Cflags of the required packages. In this case, the
    listed packages (vorbis, speex, flac) are precisely the packages that
    libfishsound provide a wrapper API for, so apps compiling against
    libfishsound really should not need their headers directly.
    This was not a problem in 0.9.1, but in 1.0.0 the FLAC headers are
    exported, and this include a really regrettably misnamed assert.h, which
    shadows the system assert.h and causes compilation of sonic-visualiser
    to fail.
    I've tried removing the Requires: line and can report that it results in
    a functioning sonic-visualiser build.
    Reported-by: hircus
Commits on May 27, 2010
  1. add TODO file with some suggested improvements.

    * Please add feature suggestions here!
    * Please remove the entry from TODO in the same commit that implements
    a feature listed there :-)
Commits on Apr 19, 2010
  1. flac: set vendor_string.length = 0

    Avoids debug crash with libFLAC 1.2.1; tested on Windows (x64)
    Reported-by: Денис Кулаков <>
Commits on Apr 10, 2010
Commits on Apr 1, 2010
Commits on Feb 3, 2010
  1. Release 1.0.0

  2. Fix compile warnings throughout

  3. Annodex #497: Fix compile warnings when encoder is disabled

    Patch by Chris Double
  4. Annodex #493: Handle comments of form "KEY="

    Handle the case where the comment has no value but has an = sign.
    Tested with the files in that bug report:
Commits on Feb 2, 2010
  1. Mozilla #520500: Allow NULL-value comments

    This commit changes the policy of fs_comment_validate_byname() to
    allow NULL-value comments, and changes fs_comment_new() to handle
    the case where value=NULL.
    This commit should pass "make check", including the policy change
    introduced in the previous commit.
  2. tests: allow NULL-valued comments

    This test changes the policy on what comments are valid, to allow
    plain comments, not of the form KEY=VALUE (the condition reported
    in Mozilla #520500).
    As this commit only modifies the test suite, 'make check' is
    expected to fail.
  3. Revert ac2015d, 46faa6b

    This reverts the following commits:
    "Mozilla 520500: test for (len > 0)"
    Revert "Mozilla 520500, Mozilla 521863"
    Due to a regression introduced by ac2015d, which fails to pass
    "make check", and chops the first character off all comment values.
Commits on Nov 23, 2009
Commits on Oct 18, 2009
  1. Mozilla 520500: test for (len > 0)

    This change was present in the patch for 520500 but not 521863.
    Applied separately after discussion with Chris Pearce.
Commits on Oct 17, 2009
  1. Mozilla 520500, Mozilla 521863

    Don't reject files with vorbis comments with name or
    values of length 0.
    Patch by Chris Pearce
Commits on Sep 15, 2009
  1. Mozilla #516323: reset packetno after seek(0)

    patch by Chris Pearce
    When resetting the decoder, reset the packetno so that the next
    packets read are treated as headers.
Commits on Sep 12, 2009
  1. Debian #534744, Mozilla #487519

    Fixes crash in vorbis_synthesis: reject bad header packets
Commits on Aug 12, 2009
Commits on Jul 4, 2009
  1. update debug_printf for MSVC

Commits on Jun 28, 2009
Commits on Jun 23, 2009
Commits on May 25, 2009
  1. use debug_printf() for debugging

Commits on May 3, 2009
  1. Fix warnings found while building mozilla

    timeless authored committed
    Removing unreachable code because type is unsigned
    Fixing signedness warnings
Commits on Apr 7, 2009
  1. Release 0.9.2

Commits on Mar 28, 2009
  1. Initialize vorbis_dsp_state to avoid a crash triggered by a Vorbis file

    conrad authored
    with corrupt headers Mozilla bug 481601.
    Adapted from a patch that fixes the crash by adding a new vorbis_dsp_init()
    function to libvorbis, and calling that from fs_vorbis_init():
    It was suggested in this thread on vorbis-dev that we isolate the patch
    to libfishsound, rather than also adding vorbis_dsp_init() to libvorbis:
    Hence, this revision should replace the patch currently in use in
    Firefox for Mozilla bug 481601.
    git-svn-id: 8158c8cd-e7e1-0310-9fa4-c5954c97daef
  2. Fix remaining libfishsound issues in Mozilla bug 480014

    conrad authored
    vorbis.c: Remove unnecessary alloca
    speex.c: Check that frame_size is not so large that the buffer size
    calculations would wrap. In reality, frame_size is set by libspeex
    according to the mode index specified in the file header, and is
    usually equal to 320. Requires uintptr_t, checked by configure.
    git-svn-id: 8158c8cd-e7e1-0310-9fa4-c5954c97daef
  3. fix detection of vorbisenc, broken by my bad merge for r3891

    conrad authored
    git-svn-id: 8158c8cd-e7e1-0310-9fa4-c5954c97daef
  4. add SNDFILE_CFLAGS to includes for examples.

    conrad authored
    Patch by Matthew Gregan:
    This is required when libsndfile is in a non-standard location,
    e.g. /opt/local/{include,libs} on OS X with MacPorts.  configure sets
    SNDFILE_CFLAGS correctly (since pkg-config is in the path),
    but the examples weren't using this value when building.
    git-svn-id: 8158c8cd-e7e1-0310-9fa4-c5954c97daef
  5. Add release notes for 0.9.1 (Released Apr 6 2008)

    conrad authored
    git-svn-id: 8158c8cd-e7e1-0310-9fa4-c5954c97daef
Commits on Mar 20, 2009
  1. check for vorbis by pkgconfig first, fallback to previous method

    conrad authored
    of directly looking up library symbols and headers.
    pkg-config patch by Viktor Gal
    git-svn-id: 8158c8cd-e7e1-0310-9fa4-c5954c97daef
Commits on Mar 19, 2009
  1. flac_decode: fail if Ogg packet length is too short

    conrad authored
    when parsing header
    For Mozilla bug 480014
    git-svn-id: 8158c8cd-e7e1-0310-9fa4-c5954c97daef
  2. clamp comment lengths to fit within 32 bits (including trailing NUL).

    conrad authored
    Fixes potential wrapping of strlen in fs_strdup, fs_strdup_len
    git-svn-id: 8158c8cd-e7e1-0310-9fa4-c5954c97daef
  3. Remove redundant copy of fish_sound_set_interleave() declaration,

    conrad authored
    and fix a typo in its documentation
    git-svn-id: 8158c8cd-e7e1-0310-9fa4-c5954c97daef
Something went wrong with that request. Please try again.