Radial gradient effect #5

Closed
wants to merge 5 commits into
from

Projects

None yet

2 participants

@marcosanson

Hi David,
nice to meet you!
I worked on your awesome library. I added the ability to configure a radial gradient under the noise. This is done in order to add a light in the centre of screen to make the noise shine. I need this feature for our iOS app so I really appreciate if you would like to merge my changes.
Of course I maintained the library compatibility with iOS and OSX.

I modified the OSX example in order to show you the difference between noise with gradient and noise without. To see it you should run osx example. The left one and right one are configured as same but the left one has the gradient and the right one no.

Let me know what you think about it.
ciao
marco

Owner
kgn commented Oct 18, 2012

Thanks for these additions! I'll get these merged in soon, thanks for committing both iOS and Mac code!

Hi David,
Glad to hear this from you. Only one thing, take the head of my fork, cause
I had to fix an issue with iOS and ARC that release the UIColor before I
could use it. I store them into CGColorRef right now.
Let me know if you need a new pull request with right git revision.
ciao
marco

On Thu, Oct 18, 2012 at 9:50 PM, David Keegan notifications@github.comwrote:

Thanks for these additions! I'll get these merged in soon, thanks for
committing both iOS and Mac code!


Reply to this email directly or view it on GitHubhttps://github.com/kgn/KGNoise/pull/5#issuecomment-9579761.

@kgn kgn closed this in 6f89947 Oct 19, 2012
Owner
kgn commented Oct 19, 2012

@marcosanson gradients on views was something I had always planned so I went with the plan I had in my head. The resulting code is different than your approach, I didn't add the gradients to NSNoise and created two new views, but it should produce similar results. Please let me know how you find it.

@rastersize rastersize added a commit to rastersize/KGNoise that referenced this pull request Dec 29, 2012
@rastersize rastersize Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Adding color categories: #2
  improved the radial gradient radius code based on @marcosanson pull request
  updating screenshot
  renaming screenshot and updating readme
  moving the default image into the iOS group
  adding KGNoiseLinearGradientView and KGNoiseRadialGradientView closes #5
  adding Default-568h@2x.png
  Minor edit to readme.md
2fe5e3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment