Permalink
Commits on Sep 5, 2013
  1. WIP: Testing slave_ok not set

    committed Sep 5, 2013
Commits on Sep 4, 2013
  1. @openstack-gerrit
Commits on Sep 3, 2013
  1. chore: Update openstack.common to get latest timeutils

    This is a simple update to marconi/openstack/common in order
    to pick up the optimized version of timeutils.utctime_ts()
    
    Change-Id: Ic37e5f271fe89085317a96c47d18ddd426529b50
    committed Sep 3, 2013
Commits on Aug 30, 2013
  1. chore: Track the up-and-coming oslo.cache module

    While we wait for oslo.cache to land, I'd like to maintain a
    verbatim copy under marconi.common so that we can start using
    it immediately.
    
    When oslo.cache is approved upstream, this copy of the code
    will go away and we will add cache to marconi's
    openstack-commong.conf
    
    Change-Id: I608a2891ca06caec47ce18eda4edacd07bec40e9
    committed Aug 28, 2013
Commits on Aug 29, 2013
  1. @lichray

    fix: claimed message require claim_id to delete

    But bulk deletion can still delete both unclaimed and claimed
    messages.  However, the major purpose to support bulk deletion
    is to make it easy for a user to issue a DELETE on the Location
    header returned from a POST; if a user intend to use claim, then
    this URI does not help.
    
    Change-Id: Ieed92fc0a07d2e873b729242fb2fb14536462780
    Closes-Bug: #1215484
    lichray committed Aug 22, 2013
  2. @openstack-gerrit
  3. @openstack-gerrit
  4. chore: Update openstack.common, add lockutils

    This patch updates openstack.common to HEAD and also adds
    lockutils to openstack-common.conf in anticipation of
    pulling in the cache module when it lands.
    
    Change-Id: I714e03c4eba9e98b92144f2b2f227799d104f1bd
    committed Aug 28, 2013
  5. @openstack-gerrit

    Merge "Refactor System Tests"

    Jenkins committed with openstack-gerrit Aug 29, 2013
  6. @malini-kamalambal

    Refactor System Tests

    This patch,
    1. Renames 'System Tests' to 'Functional Tests'.
    2. Reduces LOC by using ddt.
    3. Removes test dependencies & the numbering convention used earlier.
    4. Re-organizes the test suite structure.
    
    blueprint refactor-system-tests
    
    Change-Id: Ife236abf867b678beb72ea3a26a06d895ed8ad4b
    malini-kamalambal committed Aug 19, 2013
  7. @openstack-gerrit
Commits on Aug 26, 2013
  1. @lichray

    feat(wsgi): homedoc now ships relative URIs

    The document root can be obtained from the service catalog, so
    that users can join two URIs to access the doc.
    
    The health endpoint is removed from homedoc at the same time,
    since it's an API for diagnose, not for end-users.
    
    Change-Id: I589ff88730302bc553041ecccb9687f7dbcaa9ab
    lichray committed Aug 26, 2013
  2. @lichray @lichray

    chore: remove queue_id cruft in mongo driver

    We store queue name in message schema; there is no need to query for
    queue ID.  Some `queue_id` param are left in comments, this patch
    replaces them with `queue_name`.
    
    Change-Id: I260007f0d6091b46755f374d9e237c0a7ab372ef
    lichray committed with lichray Aug 21, 2013
  3. @lichray

    chore: increase coverage in some trivial ways

    1. Remove old functionalities;
    2. Remove testings on internal implementations;
    3. Add trivial test cases.
    
    Change-Id: I286599ea564e144783e3edbe074d4921fa5b46f6
    lichray committed Aug 15, 2013
Commits on Aug 22, 2013
  1. @openstack-gerrit
  2. @openstack-gerrit

    Merge "Update Tests for Input Validation"

    Jenkins committed with openstack-gerrit Aug 22, 2013
Commits on Aug 21, 2013
  1. @lichray @openstack-gerrit

    chore: remove unneeded statements in wsgi

    1. Falcon response's status defaults to 200, no need to set it;
    2. Message posting count checking is already covered by input
       validation.
    
    Change-Id: I905dba8bb55e6a4254b2625bb9b71c51496fd2a8
    lichray committed with openstack-gerrit Aug 19, 2013
  2. @malini-kamalambal

    Update Tests for Input Validation

    This patch updates the tests, to reflect the API changes in input
    validation. This includes adding new data driven tests and removing some
    tests that are better addressed unit tests.
    
    Tests: bp input-validation
    Tests: bug #1212389
    
    Change-Id: I8e09541b8bfa1e23804e3d13490ff755646f2127
    malini-kamalambal committed Aug 14, 2013
Commits on Aug 19, 2013
  1. @openstack-gerrit
  2. @lichray

    chore: cleanup the unit tests with ddt

    ddt stands for data-driven-tests, and it's also a Python module.
    It adds the test data as a decorator to the test methods, so that
    the test code can focus on each type of behaviors instead of using
    `for` loops internally (on the other hand, you have to split big
    tests which testing different types of behaviors into small tests).
    
    Change-Id: I1cba67c15e9bb6e5e73e26a11e08fb1390a0504a
    lichray committed Aug 16, 2013
Commits on Aug 18, 2013
  1. @alex

    Added a PyPy env to tox

    Change-Id: I518256f0a8a3e581c3d6f6f065c9b89adc8223f2
    alex committed Aug 18, 2013
Commits on Aug 16, 2013
  1. @flaper87

    Log pymongo's exception on ConnectionFailure

    Log pymongo's exception instead of hiding it. The exception is needed
    for debugging.
    
    Change-Id: I89991f956487e3f55c940f5a1aa9c204ccb2fc33
    flaper87 committed Aug 16, 2013
  2. @lichray @lichray

    fix: bad marker behaves like non-existing marker

    From the point of view of the interface, a marker should has only
    two states: returning some messages, or returning no messages.
    Currently a malformed message marker results in a 400 response,
    which makes the marker no longer opaque.
    
    This patch makes the transport respond 204 for a malformed marker
    by making storage return an empty iterator in such a case:
    
      GET /queues/q/messages?marker=malformed  ->  204
    
    This patch also include some clean up on test code.
    
    Change-Id: I1ac7d4bb42af1644bd16d6bca6b7c50a1d700e10
    Closes-Bug: #1212389
    lichray committed with lichray Aug 15, 2013
Commits on Aug 15, 2013
  1. @openstack-gerrit
  2. @openstack-gerrit
  3. @openstack-gerrit
  4. @openstack-gerrit

    Merge "Ignore *.egg dirs"

    Jenkins committed with openstack-gerrit Aug 15, 2013
  5. Don't wait for ack when deleting expired messages

    This patch simply sets write concern to 0 in the MongoDB driver,
    when removing expired messages. This shortens the amount of time
    that garbage collection takes, and slightly reduces the amount
    of traffic going between app and db servers, as well as between
    master and secondary nodes.
    
    This is a safe thing to do, since the operator will be running
    multiple GC daemons, so that in the case of a failure, the
    operation will be retried in the near future.
    
    The downside is that persistent failures to collect expired
    messages will cause the DB to grow out of control; however,
    it is expected that if this operation is failing, more than
    likely message CRUD in general is failing, which mitigates
    the risk just mentioned.
    
    Change-Id: I90950721361dacffa508624281d2e2ea8cf53724
    committed Aug 15, 2013
  6. Use req.get_param's store feature in lieu of utils.purge

    This patch removes the use of utils.purge since it is no
    longer needed in light of Falcon's relatively new "store"
    feature, which causes the target dict to only receive the
    value of the param if it is found in the request, thus
    avoiding clobbering default kwarg values, which was the
    original intent of utils.purge.
    
    As a bonus, this approach is also ~40% faster.
    
    Change-Id: I6b3d82b1f700045e50b3131902b2c7b6dc6ea13c
    Implements: blueprint v1-obvious-optimizations
    committed Aug 14, 2013
Commits on Aug 14, 2013
  1. restructure: rm -rf tools, move test requires

    To pave the path for the project structure of the future, tools/ is
    being eliminated.
    
    New commands/utils should be added as entry points and placed in cmd/
    
    tools/system-test-requires -> system-test-requirements.txt
    
    Change-Id: I14b3189f2b2a1cee6508952a46274e00514addac
    Alejandro Cabrera committed Aug 14, 2013
  2. test: delete msg w/ invalid claim isn't deleted

    Adds a test to verify the above scenario. It should be returning 204
    in this case without the message being affected.
    
    Change-Id: I74cf8ab5f7d94128ae2157a51a5e37c01ef9ca64
    Alejandro Cabrera committed Aug 14, 2013
  3. fix: fetching nonexistent message/claims raises 503s

    The proposed fix moves away from throwing an exception everytime a
    malformed ID is encountered and instead returns None. This way,
    partial bulk get and bulk deletes are possible.
    
    Storage drivers affected:
    - mongo
    - sqlite
    
    Changes/expected behavior:
    - GET /v1/queues/exists/messages/malformed => 404
    - GET /v1/queues/exists/messages?ids=malformed,malformed => 204
    - DELETE /v1/queues/exists/messages?ids=malformed,malformed => 204
    - GET /v1/queues/exists/claims/malformed => 404
    - PATCH /v1/queues/exists/claims/malformed => 404
    - DELETE /v1/queues/exists/claims/malformed => 204
    
    In partcular, regarding bulk_get on messages, malformed IDs or
    messages that are not found by ID are now ignored. bulk_delete also
    works in this fashion now.
    
    Regression tests are added to the unit test suite to reflect these
    changes.
    
    Change-Id: I4f14cd8b4cfd1dd190dccd8724c20f5fac99c629
    Closes-Bug: #1203842
    Alejandro Cabrera committed Aug 12, 2013
  4. Ignore *.egg dirs

    This patch adds *.egg to .gitignore
    
    Change-Id: Ieb2ff6bc04a101fb700419ccfabbc947725de481
    committed Aug 14, 2013
  5. @openstack-gerrit