Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type found in AWS SDK v3 client for CloudFront #1

Open
khalidx opened this issue Apr 17, 2022 · 0 comments
Open

Incorrect type found in AWS SDK v3 client for CloudFront #1

khalidx opened this issue Apr 17, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@khalidx
Copy link
Owner

khalidx commented Apr 17, 2022

In @aws-sdk/client-cloudfront, the type of the field HttpVersion for a CloudFront Distribution is defined as the following union:

http1.1 | http2

In reality, the AWS API returns the following data:

HTTP1.1 | HTTP2

This issue is for tracking the submission of this minor fix to the appropriate repository for the AWS SDK.

No bug exists in the cfs code in this repository, since we use our own manually-defined zod union type for validating this data. This is actually how this bug was caught, since we define our own types and rely on parsing data with validation rather than just relying on the TypeScript declarations provided by the AWS SDK.

@khalidx khalidx added the bug Something isn't working label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant