Karim Hamidou khamidou

Organizations

@nylas
@khamidou
  • @khamidou b536c74
    Fix bugs in the RSVP code. Notably:
@khamidou
  • @khamidou 0d8e8b9
    Regenerate gemspec for version 0.17.4
@khamidou
@khamidou
  • @khamidou 5eb5242
    Regenerate gemspec for version 0.17.3
@khamidou
  • @khamidou 5b013ae
    [iCalendar] Fix a sync-breaking error
khamidou commented on pull request nylas/sync-engine#178
@khamidou

Could you align the strings on the same column? For example, instead of this: "mx_servers": ["163mx00.mxmail.netease.com", "163mx01.mxmail.netease.…

@khamidou
  • @khamidou bb7d2f6
    [iCalendar] Fix a sync-breaking error
@khamidou
  • @khamidou ef04730
    Fix PytestTestEngine to work with the latest version of arcanist
@khamidou
  • @khamidou 4913b9b
    [Ruby] Add support for the folders & labels API
khamidou commented on pull request nylas/sync-engine#178
@khamidou

Hi Yifan, This looks good to me besides the two minor comments I've added. Also, I was wondering what's the difference between 163.com, 163.ym and …

khamidou commented on pull request nylas/sync-engine#178
@khamidou

Are you sure this is the right domain?

khamidou commented on pull request nylas/sync-engine#178
@khamidou

Please, fix the indents here and below.

khamidou commented on issue nylas/sync-engine#177
@khamidou

Sure! However, you'll need to sign our Contributor License Agreement before we can merge your pull request. Karim

@khamidou
  • @khamidou 341c357
    Fix QA bugs in invite sending
@khamidou
  • @khamidou 57c7a65
    [api] Disable updates to recurring events
@khamidou
khamidou commented on pull request nylas/nylas-nodejs#13
@khamidou

Thanks for the pull request, Jyrki! Merging it.

@khamidou
khamidou merged pull request nylas/nylas-nodejs#13
@khamidou
Add params to event.save method
5 commits with 64 additions and 6 deletions
@khamidou
  • @khamidou 6c32c2c
    [feat] Send invites to events
khamidou commented on pull request nylas/nylas-nodejs#14
@khamidou

Thanks for fixing! Merging.

@khamidou
khamidou merged pull request nylas/nylas-nodejs#14
@khamidou
Fixed calendar model not exposing readOnly state of a calendar
1 commit with 8 additions and 1 deletion
@khamidou
  • @khamidou 91d5eb9
    [feat] Send invites to events
@khamidou
  • @khamidou 17e4424
    Log bogus iCalendar files and fix this UnboundLocalError
khamidou commented on pull request nylas/nylas-nodejs#6
@khamidou

Thanks for the pull request! It looks good to me, minus the two inline comments I've added. regards, Karim ps: Don't forget to sign our CLA

khamidou commented on pull request nylas/nylas-nodejs#6
@khamidou

Could you define this method in thread.cs instead of in restful-model-collection.coffee? It makes little sense to call it on anything else than a t…