Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As of #43, the project might be incompatible with Xcode prior to 9.3 GM and Swift prior to 4.1 #45

Closed
isaac-weisberg opened this issue Apr 5, 2018 · 3 comments · Fixed by #46

Comments

@isaac-weisberg
Copy link
Contributor

isaac-weisberg commented Apr 5, 2018

The issue is discussed in commets to #43 . I will attempt to confirm this behavior today by attempting to compile master with the older toolchain. However the issue has been observed by the original PR creator when Travis said that there is no such function as compactMap since it's been added in Swift 4.1's stdlib. Overall, the #43 has essentially destroyed all the backwards compatibility that there could be.

@isaac-weisberg
Copy link
Contributor Author

Considering this breaking change in stdlib's API, my suggestion number one is to establish continuous integration running more platforms, in particular of course, latest 4.0.x and latest 4.1.x, same with Xcode, 9.2 GM and 9.3 GM

@MrNickBarker
Copy link
Contributor

MrNickBarker commented Apr 5, 2018

I have submitted #46 to fix this issue. I have tested it with Xcode 9.2 and 9.3.

Unfortunately I don't have much experience with Travis CI so adding more platforms with different swift versions would take me a while to figure out, so preferably someone more experienced can do it.

@isaac-weisberg
Copy link
Contributor Author

@MrNickBarker appreciating your rapid response! I will add another Build Job with older Xcode and older Swift on Linux in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants