Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #4 #5

Closed
wants to merge 2 commits into from

Conversation

@NetOperatorWibby
Copy link

commented Jan 6, 2019

Description of the Change

This PR adds a Boolean check to parsed queries.

Why Should This Be here?

Boolean values need to work.

Benefits

Users can use booleans in their queries.

Closes #4
Adds a Boolean check
@codecov

This comment has been minimized.

Copy link

commented Jan 9, 2019

Codecov Report

Merging #5 into master will decrease coverage by 1.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage     100%   98.76%   -1.24%     
==========================================
  Files           3        3              
  Lines          78       81       +3     
==========================================
+ Hits           78       80       +2     
- Misses          0        1       +1
Impacted Files Coverage Δ
src/modules/parser.js 97.91% <100%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e18f1b2...a2b741f. Read the comment docs.

Repository owner deleted a comment Jan 10, 2019
@khaosdoctor

This comment has been minimized.

Copy link
Owner

commented Jun 5, 2019

Closing since it's been fixed on fb9a491

@khaosdoctor khaosdoctor closed this Jun 5, 2019
@NetOperatorWibby NetOperatorWibby deleted the NetOperatorWibby:patch-1 branch Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.