New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for registering all interfaces against a single implementation #58

Merged
merged 1 commit into from Aug 29, 2018

Conversation

2 participants
@andrewlock
Contributor

andrewlock commented Aug 28, 2018

Addresses #57

Added an alternative registration extension method AsSelfWithInterfaces() that registers the type itself, and all interfaces it implements, by forwarding the interface request to the concrete type.

Added unit tests for this case, as well as confirming the existing behaviour with AsSelf() and AsImplementedInterfaces().

This was my first look at the Scrutor code - any suggestions gladly accepted 馃檪

@khellang khellang merged commit baca864 into khellang:master Aug 29, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@khellang

This comment has been minimized.

Show comment
Hide comment
@khellang

khellang Aug 29, 2018

Owner

Woah, this is a really nice PR. Very clean! 馃憤

Thanks for this. I'll see if I can get a release out (along with some other changes) tonight 馃槃

Owner

khellang commented Aug 29, 2018

Woah, this is a really nice PR. Very clean! 馃憤

Thanks for this. I'll see if I can get a release out (along with some other changes) tonight 馃槃

@khellang khellang added this to the v3.0.0 milestone Aug 29, 2018

@khellang khellang added the Feature label Aug 29, 2018

@andrewlock

This comment has been minimized.

Show comment
Hide comment
@andrewlock

andrewlock Aug 29, 2018

Contributor

Oh awesome, thanks! Really appreciate it 馃槃

Contributor

andrewlock commented Aug 29, 2018

Oh awesome, thanks! Really appreciate it 馃槃

@andrewlock andrewlock deleted the andrewlock:add-multiple-services-per-implementation branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment