Make the manpage generation reproducible. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you have any questions or queries regarding this patch - happy to help! |
Whilst working on the Reproducible Builds effort [0], we noticed that mp3fs could not be built reproducibly as it uses a locale, timezone and current-time-of-day header in the generated manpage. This patch ensures that the output is consistent regardless of the build user's location, or by the current time by utilising the SOURCE_DATE_EPOCH environment variable. [0] https://reproducible-builds.org/ [1] https://reproducible-builds.org/specs/source-date-epoch/
lamby
force-pushed
the
reproducible-build
branch
from
bb79bbe
to
95ece25
Compare
|
(Updated patch.) |
|
Thanks for your contribution, and sorry that I've sat on this for so long. I appreciate your goal here of making the build reproducible. There are actually some changes to how I would deal with differing date implementations (autoconf can make this more convenient). However, I'm just going to accept this as-is and fix that in a follow-up. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort, we noticed that mp3fs could not be built reproducibly as it uses a locale, timezone and current-time-of-date header in the generated manpage.
This patch ensures that the output is consistent regardless of the build user's location, or by the current time by utilising the
SOURCE_DATE_EPOCHenvironment variable.