Skip to content

refactor: extract Arel scalar comparisons#20

Merged
kholdrex merged 1 commit into
masterfrom
refactor/arel-scalar-comparisons
Jun 6, 2026
Merged

refactor: extract Arel scalar comparisons#20
kholdrex merged 1 commit into
masterfrom
refactor/arel-scalar-comparisons

Conversation

@kholdrex

@kholdrex kholdrex commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Summary

Refactors the Arel compiler path for scalar comparison filters so the repeated bind and predicate construction lives in one helper. The change keeps generated SQL behavior, bind ordering, and public APIs unchanged while making the compiler easier to maintain after the recent bind-key cleanup.

Changes

  • Extracts shared scalar comparison handling for =, !=, <>, >, >=, <, and <= in the Arel compiler path.
  • Keeps between, in, like, ilike, existence filters, and unsupported-operator behavior unchanged.
  • Adds focused compiler specs for scalar predicate node selection and bind-spec ordering.

Test Plan

  • Focused compiler specs passed.
  • Full RSpec suite passed.
  • RuboCop passed on the changed compiler and spec files.
  • Diff whitespace check passed.

@kholdrex kholdrex merged commit 9e5f700 into master Jun 6, 2026
34 checks passed
@kholdrex kholdrex deleted the refactor/arel-scalar-comparisons branch June 6, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant