new enhancements

[mustafauysal]

I've started to fork this plugin and I a few idea for making this plugin better.

• i18n support would be helpful for multilingual usage.
• Optional forcing zen mode (maybe it could be user role based)
• Options should be in the user_meta table, think about single wordpress that has multiple author.

What are you think about these?

[mustafauysal]

first commit for forcing zen mode - mustafauysal@6f64f71

Also I'm reformatting current code for WordPress code standarts

I'll send pull request when I finished this stuff.

Cheers,

[khromov]

Thanks for the pull request. It's a pretty big refactoring - I'm gonna try it out and get back to you shortly!

As for your points:

i18n support
Should definitely happen!

forcing zen mode
Can you specify a use case for this? Zen mode is nice but it removes a lot of functionality. I'm afraid that putting people in that mode by default would cause a lot of confusion (How do you change back?)
It's alright to have it in the settings, but I feel it needs an added warning if you activate it (Like a standard javascript prompt popping up telling you about the implications and how to get out of Zen mode.)

Options should be in the user_meta table
Great suggestion. This has been planned but I haven't gotten around to implementing it. The most clear way is probably to add a link from the user profile settings to the DFWMT settings page, which will then change the settings for the active user.

What are your thoughts on this?

[mustafauysal]

Should definitely happen!

Yes 👍

Can you specify a use case for this? Zen mode is nice but it removes a lot of functionality. I'm afraid that putting people in that mode by default would cause a lot of confusion (How do you change back?)
It's alright to have it in the settings, but I feel it needs an added warning if you activate it (Like a standard javascript prompt popping up telling you about the implications and how to get out of Zen mode.)

Actually I need this for my current project. (It'll be simple publishing platform like as medium.com) WordPress itself already has zen mode but I'm sure that many people don't know this feature.

Great suggestion. This has been planned but I haven't gotten around to implementing it. The most clear way is probably to add a link from the user profile settings to the DFWMT settings page, which will then change the settings for the active user.

It could be, also setting field in the user settings page could be useful.

Thanks!

[khromov]

Hi Mustafa,

I checked your pull requests. There are no issues with the refactoring.

As for the force distraction free writing mode functionality:

• It ony works when you create a new post. (Try editing an existing post and you'll see DFWM is not activated automatically). This is because you only check for the "post-new.php" page in the conditional. If this feature is to be added it needs to work always, as the setting implies.
• "Force Zen mode" on the admin screen should be "Force Distraction Free Writing mode". Zen isn't used as a terminology anywhere in WP afaik.
• Please move the setting to the bottom of the settings list.

Once this is done, I'll happily merge the request and push out a new version to WP.org, and then we can start focusing on future stuff like storing settings in usermeta.

Let me know what you think.

[mustafauysal]

Hi @khromov ,

As for the force distraction free writing mode functionality:
It ony works when you create a new post. (Try editing an existing post and you'll see DFWM is not activated automatically). This is because you only check for the "post-new.php" page in the conditional. If this feature is to be added it needs to work always, as the setting implies.
"Force Zen mode" on the admin screen should be "Force Distraction Free Writing mode". Zen isn't used as a terminology anywhere in WP afaik.
Please move the setting to the bottom of the settings list.

On my way ;)

Let me know what you think.

Can we release all of these enhancements in the version 2.2?

[khromov]

Can we release all of these enhancements in the version 2.2?

Yup! 👍

[mustafauysal]

Done! - mustafauysal@1340e3b

I'm working on localization. I'll use "dfwmdt" as text-domain value?

[khromov]

Yup, that should work just fine! Feel free to increment the plugin version and let me know when everything is ready.

[mustafauysal]

Localization and Turkish language pack added! - mustafauysal@f01058e

[khromov]

Great! Send a pull request when you feel it's ready to merge.

[mustafauysal]

Great! Send a pull request when you feel it's ready to merge.

Last thing to do: storing options under user_meta.

• We can put select box to users profile page but we need to remove "custom theme" functionality?
• Or only admins can edit custom theme and users can select it.

What are you think about this?

[khromov]

I think we should keep the custom CSS option but make it editable by Admin / Super admin only.

With this change it should also be possible for admins to set a default theme for new users (A dropdown should be enough for that.), as well as the default state of the "force dfwm" option for new users.

These admin settings can be placed at the bottom of the current settings screen, perhaps under a new label called "Admin options".

[mustafauysal]

I think we should keep the custom CSS option but make it editable by Admin / Super admin only.
Options page already working only admins.

I've worked and users can select their theme from profile page. - mustafauysal@2975c7c

If they don't select theme, they will use theme that selected by admin.

Maybe we need to make this feature optional. I'm not sure yet.

If everything ok, I'll send pull request.

[khromov]

That looks good! Go ahead and send the pull request. 👍

[khromov]

Hi Mustafa,

I added some fixes to your PR.

The templates are moved from the main plugin file into separate files.

Also added support for selecting the Default Admin theme or the WordPress default theme from the user settings page. Before it was not possible to use the default WP theme, or revert to the admin selected theme.

What is still missing is a user option to force default DFW mode on the user level. I'll jump on that tomorrow.

Here is the commit:
997569d