Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate metrics for validators #4230

Closed
jmazzitelli opened this issue Jul 28, 2021 · 0 comments · Fixed by #4248
Closed

generate metrics for validators #4230

jmazzitelli opened this issue Jul 28, 2021 · 0 comments · Fixed by #4248
Assignees
@jmazzitelli
Labels
enhancement This is the preferred way to describe new end-to-end features.
Projects
Sprint 61 (v1.39)

Comments

@jmazzitelli
Copy link
Collaborator

jmazzitelli commented Jul 28, 2021 •
edited

Today we generate metrics for each API call and for each appender and other things. This way we can examine the performance of those individual pieces of the code (even on customer machines) by looking at the metrics in prometheus or the kiali dashboard.

We should do the same for the individual validators so we can track performance of those as well.

PR: #4248
backport PR: #4250
@jmazzitelli jmazzitelli added enhancement This is the preferred way to describe new end-to-end features. area/scalability labels Jul 28, 2021
jmazzitelli added a commit to jmazzitelli/kiali that referenced this issue Aug 2, 2021
@jmazzitelli
add metric to track processing time for each individual checker
cde0154 
fixes: kiali#4230
@jmazzitelli jmazzitelli mentioned this issue Aug 2, 2021
Merged
jmazzitelli added a commit that referenced this issue Aug 3, 2021
@jmazzitelli
add metric to track processing time for each individual checker (#4248)
a623a64 
* add metric to track processing time for each individual checker
fixes: #4230

* metric for the full namespace/service validation

* add metric for validating a single istio object
jmazzitelli added a commit to jmazzitelli/kiali that referenced this issue Aug 3, 2021
@jmazzitelli
add metric to track processing time for each individual checker (kial…
f64df78 
…i#4248)

* add metric to track processing time for each individual checker
fixes: kiali#4230

* metric for the full namespace/service validation

* add metric for validating a single istio object
@jmazzitelli jmazzitelli added this to Backlog in Sprint 61 (v1.39) via automation Aug 3, 2021
@jmazzitelli jmazzitelli self-assigned this Aug 3, 2021
jmazzitelli added a commit that referenced this issue Aug 3, 2021
@jmazzitelli
add metric to track processing time for each individual checker (#4248)…
86fac4c 
… (#4250)

* add metric to track processing time for each individual checker
fixes: #4230

* metric for the full namespace/service validation

* add metric for validating a single istio object
@lucasponce lucasponce moved this from Backlog to In Review in Sprint 61 (v1.39) Aug 9, 2021
@jshaughn jshaughn moved this from In Review to Done in Sprint 61 (v1.39) Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmazzitelli jmazzitelli

Labels
enhancement This is the preferred way to describe new end-to-end features.
Projects
No open projects
Sprint 61 (v1.39)
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add metric to track processing time for each individual checker jmazzitelli/kiali
1 participant
@jmazzitelli