Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-619 Add route rule appender #179

Merged
merged 1 commit into from Apr 27, 2018

Conversation

@jshaughn
Copy link
Contributor

commented Apr 26, 2018

  • make public the individual IstioClientGetIstioDetails methods to allow
    for more targeted calls from the appenders.
  • update CB appender to use GetDestinationPolicies() directly
  • change some "isXxx" field names to "hasXxx" where appropriate
  • shorten some json field names where appropriate
- make public the individual IstioClientGetIstioDetails methods to allow
  for more targeted calls from the appenders.
- update CB appender to use GetDestinationPolicies() directly
- change some "isXxx" field names to "hasXxx" where appropriate
- shorten some json field names where appropriate
@jshaughn jshaughn requested a review from jmazzitelli Apr 26, 2018
@jshaughn

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2018

@jotak This PR includes publicizing a few IstioClient methods. Please let me know if it's OK with you. I don't think it should block this PR, we can resolve any issues going forward.

@jshaughn jshaughn added do not merge and removed do not merge labels Apr 26, 2018
@jotak

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2018

@jshaughn it makes totally sense to me, +1

@jmazzitelli jmazzitelli merged commit 5332dee into kiali:master Apr 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jshaughn jshaughn deleted the jshaughn:kiali-619-good branch Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.