Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for nil #211

merged 1 commit into from May 24, 2018


Copy link

commented May 24, 2018

without this fix. PR #208 blows up

@jshaughn jshaughn merged commit 2a68351 into kiali:master May 24, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@jmazzitelli jmazzitelli deleted the jmazzitelli:fix-npe branch May 24, 2018

This comment has been minimized.

Copy link

commented May 24, 2018

It seems I relied in the tests and I didn't notice there was no tests for this one.
Thx for the fix.
I will add more tests for this use case.
Travis passed on #208 and made think the PR was good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.