Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-761 Support self-invoking services in the graph #250

Merged
merged 1 commit into from Jun 11, 2018

Conversation

@jshaughn
Copy link
Contributor

commented Jun 6, 2018

No description provided.

@jshaughn jshaughn requested a review from jmazzitelli Jun 6, 2018
@jshaughn

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2018

screenshot

@josejulio

This comment has been minimized.

Copy link
Member

commented Jun 11, 2018

@jshaughn I suspect the animation is broken with this (on loops) I didn't added support for curves, but can work on this after this PR

@jshaughn

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2018

The animation is kind of funny with what it does bit it's ok. Doesn't do anything crazy. But you are right. there is no dot moving on the self-referencing edge.

Copy link
Contributor

left a comment

When I look at this PR, it takes me back to when I was a child frolicking in the meadows smelling the sweet fragrance of wild flowers.

@jmazzitelli jmazzitelli merged commit 94fea74 into kiali:master Jun 11, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jshaughn jshaughn deleted the jshaughn:kiali-761 branch Jun 11, 2018
@lucasponce

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2018

When I look at this PR, it takes me back to when I was a child frolicking in the meadows smelling the sweet fragrance of wild flowers.

Nice that a PR makes you remember those poems of Walt Whitman :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.