Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-1121 VirtualServices are filtered by host from routes #344

Merged
merged 1 commit into from Jul 10, 2018

Conversation

@lucasponce
Copy link
Contributor

commented Jul 10, 2018

Main change for this fix is to filter services by host defined in routes.

VirtualServices "hosts" field can be anything:
https://istio.io/docs/reference/config/istio.networking.v1alpha3/#VirtualService

So, it is not correct to link the services by that field, instead, using the host defined within the routes, it filter correctly from services from the mesh.

@lucasponce lucasponce requested a review from xeviknal Jul 10, 2018
Copy link
Member

left a comment

LGTM! Thanks to that, VirtualServices and Destination Rules are filtered by the host where they point to.

However, the endless nested operations, IMO, are a code smell. Of course, it is something that is happening into the whole project and not subject of this PR.

@xeviknal xeviknal merged commit 5ceaa68 into kiali:master Jul 10, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lucasponce lucasponce deleted the lucasponce:filter_vs_by_routes branch Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.