KIALI-1347 Add type in workloadEndpoint Details and validations by Workload #433
Conversation
doc.go
Outdated
| @@ -216,6 +223,10 @@ type NamespaceValidations map[string]TypedIstioValidations | |||
| // swagger:model | |||
| type TypedIstioValidations map[string]NameIstioValidation | |||
|
|
|||
| // List of validations grouped by workload | |||
| // swagger:model | |||
| type WorkloadValidations map[string]models.IstioValidation | |||
There was a problem hiding this comment.
I'm just wondering, as just below there's a type defined "List of validations grouped by object name" : wouldn't it be like a more generic thing for the one you're creating? Can it be reused, from a logical point of view? (technically it's the same, but logically I don't know if it makes sense)
|
Added Do Not Merge label. |
| validations := make([]*models.IstioCheck, 0) | ||
| valid := true | ||
| if _, appLabel := pod.Labels["app"]; !appLabel { | ||
| //do something here |
There was a problem hiding this comment.
you can probably remove this comment?
There was a problem hiding this comment.
Hahaha Yeah sorry xD
| } | ||
|
|
||
| if _, versionLabel := pod.Labels["version"]; !versionLabel { | ||
| //do something here |
There was a problem hiding this comment.
you can probably remove this comment?
| pod.Parse(checker.Pod) | ||
| validations := make([]*models.IstioCheck, 0) | ||
| valid := true | ||
| if _, appLabel := pod.Labels["app"]; !appLabel { |
There was a problem hiding this comment.
String "app" should not be hard-coded but taken from config (AppLabelName)
| validations = append(validations, &check) | ||
| } | ||
|
|
||
| if _, versionLabel := pod.Labels["version"]; !versionLabel { |
There was a problem hiding this comment.
String "version" should not be hard-coded but taken from config (VersionLabelName)
| @@ -65,6 +65,23 @@ func (in *IstioValidationsService) GetNamespaceValidations(namespace string) (mo | |||
| return models.NamespaceValidations{namespace: runObjectCheckers(objectCheckers)}, nil | |||
| } | |||
|
|
|||
| func (in *IstioValidationsService) GetWorkloadValidations(namespace string, workload string) (models.IstioValidations, error) { | |||
| selector, err := in.k8s.GetDeploymentSelector(namespace, workload) | |||
There was a problem hiding this comment.
very good!
Workload may not be a deployment, but we don't care much about that yet. So that's fine
There was a problem hiding this comment.
We should refactor this and the Workload model with the new objects in the future
|
@jotak comments addressed, thanks |
|
@aljesusg this needs a rebase before to give it a final review. Thx |
|
Rebased |
** Describe the change **
Added the type to the Workload Details Endpoint
Added Endpoint to check labels and IstioSidecar Validations related a Workload
Fake validation
** Issue reference **
KIALI-1347
** Backwards incompatible? **
Yes