Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-1244 Post-refactor cleaning/verification aftewr workloads #453

Merged
merged 1 commit into from Aug 24, 2018

Conversation

@aljesusg
Copy link
Contributor

commented Aug 24, 2018

** Describe the change **

Refactor and clean after workloads

  • We used the same values in the configuration file

** Issue reference **

KIALI-1244

@aljesusg aljesusg requested a review from lucasponce Aug 24, 2018
@@ -140,8 +135,6 @@ func NewConfig() (c *Config) {
c.Identity.CertFile = getDefaultString(EnvIdentityCertFile, "")
c.Identity.PrivateKeyFile = getDefaultString(EnvIdentityPrivateKeyFile, "")
c.InCluster = getDefaultBool(EnvInCluster, true)
c.AppLabelName = strings.TrimSpace(getDefaultString(EnvAppLabelName, "app"))
c.VersionLabelName = strings.TrimSpace(getDefaultString(EnvVersionLabelName, "version"))
c.KialiService = strings.TrimSpace(getDefaultString(EnvKialiService, "kiali"))
c.IstioNamespace = strings.TrimSpace(getDefaultString(EnvIstioNamespace, "istio-system"))
c.IstioLabels.AppLabelName = strings.TrimSpace(getDefaultString(EnvIstioLabelNameApp, "app"))

This comment has been minimized.

Copy link
@lucasponce

lucasponce Aug 24, 2018

Contributor

Good catch. "app" was repeated in the config.

appLabel := config.Get().AppLabelName
pods, err := in.k8s.GetPods(namespace, appLabel+"="+service)
// Get serviceDetails from a Namespace and service
serviceDetails, err := in.k8s.GetServiceDetails(namespace, service)

This comment has been minimized.

Copy link
@lucasponce

lucasponce Aug 24, 2018

Contributor

+1
Good one, previous code fetched pods directly without using service selector.

Copy link
Contributor

left a comment

LGTM

@lucasponce lucasponce merged commit e7dbfbd into kiali:master Aug 24, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.