Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-1414 Fix sidecar appender when no version label #458

Merged
merged 1 commit into from Aug 27, 2018

Conversation

@israel-hdez
Copy link
Member

commented Aug 24, 2018

Graph sidecar appender was mistakenly also checking pod labels. This was causing the graph to show the missing sidecar badge even if all pods correctly have sidecars.

Fixing issue and adding tests to avoid future regressions.

** Backwards incompatible? ** It's compatible

@israel-hdez israel-hdez requested review from xeviknal and jmazzitelli Aug 24, 2018
@israel-hdez israel-hdez force-pushed the israel-hdez:kiali-1414 branch from 527aa17 to ecd0278 Aug 24, 2018
Graph sidecar appender was mistakenly also checking pod labels. This was causing the graph to show the missing sidecar badge even if all pods correctly have sidecars.

Fixing issue and adding tests to avoid future regressions.
@israel-hdez israel-hdez force-pushed the israel-hdez:kiali-1414 branch from ecd0278 to a64b6c0 Aug 24, 2018
Copy link
Contributor

left a comment

LGTM

@jshaughn jshaughn merged commit 531eab3 into kiali:master Aug 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@israel-hdez israel-hdez deleted the israel-hdez:kiali-1414 branch Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.