Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: change intro question #478

Merged
merged 1 commit into from Oct 10, 2018

Conversation

@jotak
Copy link
Contributor

commented Sep 4, 2018

I think it's more correct to reformulate the question, because Kiali doesn't know anything about what a service is doing, beyond its interactions. We have no idea of the services business value.

See also kiali/kiali.io#20

README.adoc Outdated
@@ -6,7 +6,7 @@ toc::[]

== Introduction

Kiali provides answers to the question _What are the microservices in my Istio service mesh doing?_
Kiali provides answers to the questions: _What are the microservices in my Istio service mesh, and how are they connected?_

This comment has been minimized.

Copy link
@abonas

abonas Sep 4, 2018

Collaborator

Maybe "What/which microservices exist in my Istio service mesh" instead of "what are ....", otherwise I feel it misses a verb :)
@JStickler ?

This comment has been minimized.

Copy link
@JStickler

JStickler Sep 24, 2018

I would choose either "What microservices are part of my service mesh and how are they connected?" or "Which microservices exist in my service mesh and how are they connected?"

This comment has been minimized.

Copy link
@abonas

abonas Oct 9, 2018

Collaborator

@jotak have you addressed @JStickler comments?

This comment has been minimized.

Copy link
@jotak

jotak Oct 9, 2018

Author Contributor

done

@pilhuhn

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2018

I'd merge that now, as the counterpart on kiali.io has been merged.

@jotak jotak force-pushed the jotak:readme-intro branch from b717b37 to 98bae42 Oct 9, 2018
@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2018

✔️ Jenkins CI: kiali-core-pr-e2e-test #158

KIALI_NAME=kialicorepr478-istio-system

@abonas
abonas approved these changes Oct 10, 2018
@abonas abonas merged commit 6e31850 into kiali:master Oct 10, 2018
2 checks passed
2 checks passed
Jenkins-CI Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.