Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-1598 Support service node detail graph #517

Merged
merged 1 commit into from Sep 25, 2018

Conversation

@jshaughn
Copy link
Contributor

commented Sep 24, 2018

  • also improve readability:
    • remove some dead code
    • remove escaped-quotes from some query strings
    • use %s (as opposed to %v) where appropriate in sprintf
@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Sep 24, 2018

✔️ Jenkins CI: kiali-core-pr-e2e-test #90

KIALI_NAME=kialicorepr517-istio-system

@jmazzitelli

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2018

Added DNM label - I think something might be wrong, particularly with TCP services. See: kiali/kiali-ui#703 (comment)

- also improve readability:
  - remove some dead code
  - remove escaped-quotes from some query strings
  - use %s (as opposed to %v) where appropriate in sprintf
@jshaughn jshaughn force-pushed the jshaughn:kiali-1598 branch from f611c81 to 659efe6 Sep 25, 2018
@jshaughn jshaughn removed the do not merge label Sep 25, 2018
@jshaughn

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2018

@jmazzitelli The mongo service is fixed, I had to change to source-side reporting as destination-side reporting was not setting the destination_service_name.

Copy link
Contributor

left a comment

looks good now

@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Sep 25, 2018

✔️ Jenkins CI: kiali-core-pr-e2e-test #93

KIALI_NAME=kialicorepr517-istio-system

@jshaughn jshaughn merged commit dd82a18 into kiali:master Sep 25, 2018
2 checks passed
2 checks passed
Jenkins-CI Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jshaughn jshaughn deleted the jshaughn:kiali-1598 branch Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.