Join GitHub today
KIALI-1578 KIALI-1136 Show WARN on all DRs with duplicate hosts #521
Sorry for my delay to jump on the review.
We invoke the ServiceValidations which includes the VR validations from the backend:
So, I think DR should also apply here as well, and potentially the UI should also shown same scheme of icons as happens in the Istio Config.
Also, I am not sure if perhaps we can change this to avoid inconsistencies between the Istio Config validations vs the Service Validations and perhaps the Service Details UI should get the list of services and invoke the same logic used in the Istio Config (I see some duplication here we introduced in the past, not on this PR).
Anyway, let me know what do you think.
Perhaps it's a good moment to refactor this area, clean the duplication between validation and simplify the endpoints used.
I.e. instead to have a validation for istio_config and other for service details; service details can provide the vs/dr and UI invoke the istio_config validations (as similar way it happens with the health).
Yes, I think the validation should happen in a refactored way. That serviceValidations is missing multiple validations, including noServiceChecker for VirtualServices since these are all defined in different places. Thus, the whole code is quite spaghetti with duplication of data.
This is a known technical debt because original design was to validate per object, at the moment we introduced two views for same object (VS can be shown under ServiceDetails and Istio Config) we maintained the backend endpoint for validations trying to sync on the backend.
But we don't have goto sentences in the code :-) jumping from one place to another without logic.
So, now it is good moment to refactor and simplify this.