Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWS-117 CORS config flag #53

Merged
merged 1 commit into from Feb 21, 2018

Conversation

@jotak
Copy link
Contributor

commented Feb 21, 2018

No description provided.

@jotak jotak requested a review from jmazzitelli Feb 21, 2018
Copy link
Contributor

left a comment

LGTM

@jmazzitelli jmazzitelli merged commit 68e0d74 into kiali:master Feb 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abonas

This comment has been minimized.

Copy link
Collaborator

commented Feb 21, 2018

does this require any update to the readme?

@jmazzitelli

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2018

@abonas the README does document all the env var/config settings - so technically yes.

However, I question if we want to maintain that section of the README. It might get out of date quick if people don't remember to keep updating it. So it may be best if we just get rid of it.

That said, without it, we really don't have a place that documents the config settings. Not sure where we could document it now other than the README.

So I'm not sure what to do.

@jmazzitelli jmazzitelli referenced this pull request Feb 21, 2018
@jmazzitelli

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2018

See PR #58 - I added the missing configs to README

@jotak jotak deleted the jotak:cors-flag branch Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.