KIALI-1698 Limit VS badging to Service Nodes #542
Conversation
|
@lucasponce I added you as a reviewer just so you would see this, because it's related to your KIALI-1680 jira. If you have any comments please add, even if this is already merged. |
graph/appender/istio_details.go
Outdated
| } | ||
| } | ||
| default: | ||
| if n.Version == "" || n.Version == graph.UnknownVersion { |
There was a problem hiding this comment.
Why skip if version is ""? If this is an app node, would it be possible for a CB to be on the node? i.e. doesn't CheckDestinationRuleCircuitBreaker accept a "" version?
There was a problem hiding this comment.
@jmazzitelli , I agree. In fact I've re-thought and formalized the scenarios. Please see the related Jira comment. If you are OK with the scenarios you can then ensure the PR actualizes the design.
jshaughn
force-pushed
the
kiali-1698
branch
2 times, most recently
from
00b0c80
to
10a798b
Compare
Here are the rules applied: - VS Badging is done only on service nodes in the graph. - CB Badging is done on a Service node with a CB destination rule or a subset with a CB destination rule - note: CB dest rule = traffic policy of outlierDetection or connectionPool - CB Badging is done on a destination App node handling a CB-service. - CB Badging is done on a destination VersionedApp node handling a CB-service with CB destination rule subset relevant to the version. - CB Badging is not done on a App Box containing a CB-badged node. CB Badging is never done on an App Box. It is too noisy as the relevant member node will already be badged.
|
I create bookinfo-ratings-delay.yaml, I see these - looks correct. note we only see the badge on the service (triangle) nodes:
|
|
@jmazzitelli All of those screenshots seem correct to me. We only apply VS badges to service nodes to indicate which service definitions are virtual services in Istio. This is in line with the details pages in Kiali, where VS and DR are shown on the service detail pages. |
There was a problem hiding this comment.
I think this is working as per the design documented in the JIRA.
@lucasponce you should take a look.
the behavior of our checking call the on-screen behavior is unchanged (meaning
that the service node will not get badged if the traffic policy is defined
only in subsets)