[OSSM-1216] cypress container #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScriptingShrimp
added
the
test: front-end/cypress
ScriptingShrimp
commented
Apr 13, 2023
FilipB
requested changes
Apr 14, 2023
I asked team where to put it, looks like everyone is fine with |
ScriptingShrimp
commented
May 5, 2023
Comment on lines
+1
to
+4
| _output | ||
| operator | ||
| deploy | ||
| frontend/node_modules |
There was a problem hiding this comment.
this will affect other Dockerfiles in this folder, is that safe @FilipB
There was a problem hiding this comment.
It should be safe as other images are build using CONTEXT ${OUTDIR}/docker, e.g. https://github.com/kiali/kiali/blob/master/make/Makefile.container.mk#L17
There was a problem hiding this comment.
I don't understand it precisely, but I believe you 😄
ScriptingShrimp
added a commit
to ScriptingShrimp/kiali
that referenced
this pull request
May 5, 2023
* initial commit for cypress container * removin old fix for chrome * cleanup and yarn --force * removing user * OSSM-3670: updating cypress dockerfile to make it work on OCP * copy also hack scripts which will be used to install demo apps --------- Co-authored-by: Filip Brychta <fbrychta@redhat.com>
FilipB
added a commit
that referenced
this pull request
May 5, 2023
* initial commit for cypress container * removin old fix for chrome * cleanup and yarn --force * removing user * OSSM-3670: updating cypress dockerfile to make it work on OCP * copy also hack scripts which will be used to install demo apps --------- Co-authored-by: Filip Brychta <fbrychta@redhat.com>
pantianying
pushed a commit
to pantianying/kiali
that referenced
this pull request
Jun 14, 2023
* initial commit for cypress container * removin old fix for chrome * cleanup and yarn --force * removing user * OSSM-3670: updating cypress dockerfile to make it work on OCP * copy also hack scripts which will be used to install demo apps --------- Co-authored-by: Filip Brychta <fbrychta@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration of docker file for cypress execution in container