Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWS 155: kubernetes scripts #67

Merged
merged 1 commit into from Feb 27, 2018

Conversation

@jmazzitelli
Copy link
Contributor

commented Feb 26, 2018

This gets k8s deployment to work. Also includes hack scripts to get istio and bookinfo installed easily on k8s. I use minishift, but the hack scripts don't require that.

@jmazzitelli

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2018

still cleaning up and testing.. do not merge

@jmazzitelli

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2018

tested on both OpenShift Origin 3.7 and Kubernetes/Minikube - all works. Ready for review and merge.

@jmazzitelli

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2018

note that kubernetes issue #52787 talks about templating and they do not want to add a template feature in kubectl itself, but several people do recommend use of envsubst which is what we use in the Makefile. So we are within the mainstream.

@jmazzitelli jmazzitelli changed the title kubernetes scripts SWS 155: kubernetes scripts Feb 26, 2018
@cfcosta

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2018

LGTM, great work!
Tested with minikube, it worked.

@jmazzitelli

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2018

I added some notes about this in the README. There is also a README in the hack/istio folder to help document these.

… also moves away from openshift templates to the same envsubst mechanism - now the yaml files are very similar between os and k8s.
@theute
theute approved these changes Feb 27, 2018
Copy link
Contributor

left a comment

I trust the other reviewers (who apparently can't Approve a PR at the moment)

@theute theute merged commit 47dbdb8 into kiali:master Feb 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmazzitelli jmazzitelli deleted the jmazzitelli:k8s-hack branch Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.