Join GitHub today
KIALI-2207 Do not round timeseries when rounded result affect signifi… #773
So unless I'm mistaken, Prometheus is going to evaluate twice the inner query as it doesn't do deduplicating when parsing the whole query.
In practice if we run
Obviously it is a performance hit but I think it should be reasonable and hardly noticeable unless you're returning 10s of thousands of series.
jshaughn left a comment
@jotak OK, so it seems there will be perf impact to take care of this corner case but the impact is likely not terrible. The only alternative I see would be to perform the query and then check the results for 0.001 and then redo things if necessary. I doubt it's worth that added complexity.
israel-hdez left a comment
I'm OK with the change.
However, since this is only covering one very specific case, makes me wonder if it's OK to round (or "process") numbers at server side. For me, it would be better if rounding happens at UI side, where needed. But that's a larger effort. So, this is OK.