Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-2323 Add index to the protocol yaml path #820

Merged
merged 2 commits into from Feb 5, 2019

Conversation

@burmanm
Copy link
Contributor

commented Feb 1, 2019

** Describe the change **

If there are multiple http routes with validation issues in the latter parts, then the validation is displayed in the wrong place. This adds index to the protocol part.

** Issue reference **

KIALI-2323

@burmanm burmanm requested a review from lucasponce Feb 1, 2019
@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Feb 1, 2019

Jenkins CI: kiali-core-pr-e2e-test #491

  • ✔️ run-kiali-e2e-tests #[1126]
@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Feb 1, 2019

Jenkins CI: kiali-core-pr-e2e-test #492

  • ✔️ run-kiali-e2e-tests #[1127]
@lucasponce

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

Tested:
image

@lucasponce lucasponce merged commit bfa8334 into kiali:master Feb 5, 2019
3 checks passed
3 checks passed
Jenkins-CI Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - tests/e2e/requirements.txt (theute) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.