Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-2359 Add Prometheus configuration to the Kiali public config #836

Merged
merged 3 commits into from Feb 12, 2019

Conversation

@jshaughn
Copy link
Contributor

commented Feb 8, 2019

  • Add GetConfiguration and GetFlags to the Prometheus client
  • Add prom scrapeInterval and retention info to PublicConfig
- Add GetConfiguration and GetFlags to the Prometheus client
- Add prom scrapeInterval and retention info to PublicConfig
jshaughn added 2 commits Feb 12, 2019
@jshaughn jshaughn requested a review from mattmahoneyrh Feb 12, 2019
@jshaughn jshaughn requested a review from israel-hdez Feb 12, 2019
Copy link
Member

left a comment

LGTM

@jshaughn jshaughn merged commit 5e5ddce into kiali:master Feb 12, 2019
3 checks passed
3 checks passed
Jenkins-CI Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - tests/e2e/requirements.txt (theute) No manifest changes detected
@jshaughn jshaughn deleted the jshaughn:kiali-2359 branch Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.