Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-2429 Show namespace-wide mTLS in the overview card #912

Merged
merged 7 commits into from Mar 15, 2019

Conversation

@xeviknal
Copy link
Member

commented Mar 13, 2019

** Describe the change **
Show namespace mTLS information into Overview Page.
For each namespace card we show:

  • If meshwide is enabled:
  1. NS is explicitely enabled too: Full lock. [1]
  2. NS is partly enabled: Hollow lock.
  3. NS is explicitely disabled: No lock. [2]
  4. No explicit mTLS setting: Full lock.
  • if meswide is disabled:
  1. NS is explicitely enabled too: Full lock. [1]
  2. NS is partly enabled: Hollow lock.
  3. NS is explicitely disabled: No lock [2]
  4. No explicit mTLS setting: No lock.

Testing files:
[1] nswide-mtls-enabled
[2] nswide-mtls-disabled

** Issue reference **
https://issues.jboss.org/browse/KIALI-2429

** Required Pull Request **
kiali/kiali-ui#1060

@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Mar 13, 2019

Jenkins CI: kiali-core-pr-e2e-test #684

  • ✔️ run-kiali-e2e-tests #[1425]
@xeviknal xeviknal requested review from lucasponce and aljesusg Mar 13, 2019
Copy link

left a comment

Verified all the mentioned 8 scenarios

@lucasponce

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Would you mind to rebase with master (and the UI one)?
I'm having some issues (unrelated with the PR I think) with the login, but I experimented them in your PR:
image

I guess that is solved when rebasing, but just to be sure before to create a blocker.

@lucasponce

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Ok, it seems that when cookie is wrong (due a previous installation) Kiali doesn't exit from this error page.
I'd say it's unrelated to this PR so I filled a JIRA to work on that separately
https://issues.jboss.org/browse/KIALI-2555

@@ -79,12 +79,6 @@ var apiToVersion = map[string]string{
kubernetes.RbacGroupVersion.Group: kubernetes.ApiRbacVersion,
}

const (
MeshmTLSEnabled = "MESH_MTLS_ENABLED"

This comment has been minimized.

Copy link
@lucasponce

lucasponce Mar 14, 2019

Contributor

Is this removed / changed ?
Because I understand this value is sent to the UI. Right ?
I ask because the Istio Wizard use this value to pre-set the TLS value.

}

const (
MTLSEnabled = "MTLS_ENABLED"

This comment has been minimized.

Copy link
@lucasponce

lucasponce Mar 14, 2019

Contributor

Ok, I see that there is a refactoring of these from istio_config to this tls business.
But it seems the constants has changed, I think this needs to be propagated to the UI side as well.

@xeviknal xeviknal force-pushed the xeviknal:KIALI-2429 branch from ff1cb80 to 5588ad0 Mar 14, 2019
@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2019

Jenkins CI: kiali-core-pr-e2e-test #696

  • ✔️ run-kiali-e2e-tests #[1436]
…pute wizards security defaults
@xeviknal

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

@lucasponce comments approached. Plus, now I am passing to service details information about ns mtls status in order to sync wizards's TLS dropdown.

@xeviknal xeviknal force-pushed the xeviknal:KIALI-2429 branch from bf456cc to 951e0c7 Mar 14, 2019
@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2019

Jenkins CI: kiali-core-pr-e2e-test #698

  • ✔️ run-kiali-e2e-tests #[1437]
@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2019

Jenkins CI: kiali-core-pr-e2e-test #699

  • ✔️ run-kiali-e2e-tests #[1438]
@lucasponce lucasponce merged commit fb6993c into kiali:master Mar 15, 2019
3 checks passed
3 checks passed
Jenkins-CI Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - tests/e2e/requirements.txt (theute) No manifest changes detected
@xeviknal xeviknal deleted the xeviknal:KIALI-2429 branch Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.