Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-2610 Remove unused data from Services and Workload details endpoints #941

Merged
merged 3 commits into from Mar 25, 2019

Conversation

@israel-hdez
Copy link
Member

commented Mar 22, 2019

This is code cleanup.

The destinationServices attribute of the WorkloadDetails endpoint and the dependencies attribute of the ServiceDetails endpont are no longer used in the front-end. Thus, removing this data from the JSON and also removing all involved code.

This is, probably, non-backwards compatible for the front-end side, since there will be missing JSON properties.

israel-hdez added 3 commits Mar 22, 2019
The destination services data is no longer used in the front-end. Thus, removing it from the JSON and also removing all involved code.
The dependencies data is no longer used in the front-end. Thus, removing it from the JSON and also removing all involved code.
@israel-hdez israel-hdez requested review from jotak and jshaughn Mar 22, 2019
@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Mar 22, 2019

Jenkins CI: kiali-core-pr-e2e-test #739

  • ✔️ run-kiali-e2e-tests #[1503]
@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Mar 22, 2019

Jenkins CI: kiali-core-pr-e2e-test #740

  • ✔️ run-kiali-e2e-tests #[1504]
@jotak
jotak approved these changes Mar 25, 2019
Copy link
Contributor

left a comment

Tested locally, LGTM

@israel-hdez israel-hdez merged commit 7e9d72d into kiali:master Mar 25, 2019
3 checks passed
3 checks passed
Jenkins-CI Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - tests/e2e/requirements.txt (theute) No manifest changes detected
@israel-hdez israel-hdez deleted the israel-hdez:kiali-2610 branch Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.