Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIALI-2658 Fix missing kind in *Binding Istio CRDs #969

Merged
merged 2 commits into from Apr 3, 2019

Conversation

@lucasponce
Copy link
Contributor

commented Apr 3, 2019

Fix missing fields in Istio config mapping.

https://issues.jboss.org/browse/KIALI-2658

@lucasponce lucasponce requested review from hhovsepy and xeviknal Apr 3, 2019
@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

Jenkins CI: kiali-core-pr-e2e-test #790

  • ✔️ run-kiali-e2e-tests #[1601]
@rhqci

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

Jenkins CI: kiali-core-pr-e2e-test #792

  • ✔️ run-kiali-e2e-tests #[1603]
@lucasponce

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

I found another missing. I'll send another commit.

@lucasponce lucasponce removed the do not merge label Apr 3, 2019
@lucasponce

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

No, it's fine.
This is ready for review @hhovsepy

Copy link

left a comment

Verified:
Screenshot from 2019-04-03 14-08-13
Screenshot from 2019-04-03 14-08-28

@lucasponce lucasponce merged commit f30bafc into kiali:master Apr 3, 2019
3 checks passed
3 checks passed
Jenkins-CI Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - tests/e2e/requirements.txt (theute) No manifest changes detected
@lucasponce lucasponce deleted the lucasponce:missing-kind-istioconfig branch Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.