New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloning operations to not create needless objects #9

Closed
marrus-sh opened this Issue Apr 20, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@marrus-sh
Copy link
Contributor

marrus-sh commented Apr 20, 2018

As it stands, the amount of cloning in the Core spec would create a number of extra (needless?) objects, as each clone of a Mon would create a new Species instead of simply using the existing one.

When cloning foreign non-Actor objects, only one clone should ever be made for any given id, and it should just be updated/replaced when a new clone needs to be made. The original source object—in its entirety—can be stored in the as:source property defined by ActivityPub.

(The spec should be updated to clarify that local non-Actor objects need not be cloned.)

@marrus-sh

This comment has been minimized.

Copy link
Contributor Author

marrus-sh commented Apr 23, 2018

Re-wrote these algorithms to fix in adadf39

@marrus-sh marrus-sh closed this Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment