Skip to content

Feature/link target#205

Merged
kickscondor merged 2 commits intokickscondor:masterfrom
rafapaezbas:feature/link-target
May 3, 2021
Merged

Feature/link target#205
kickscondor merged 2 commits intokickscondor:masterfrom
rafapaezbas:feature/link-target

Conversation

@rafapaezbas
Copy link

Hello,

I am new to Open Source contributions and this is the first PR I do to a Open Source project, honestly its only kind of an experiment because I would like to learn how to contribute.

I have seen issue #203, and I thought I could give it a try. I am not familiar with Hyperapp architecture, but I have tried following the way settings work in the app.

This settings option is only visible for the web extension because for the App, the links are always open in a different window.

Thank you very much for your time and your work, that I think is really amazing!

Best regards,
Rafa

@kickscondor
Copy link
Owner

This is so cool! Thank you, Rafa. I'm sorry I haven't been around enough to inspect this. But it looks good and I hope to get this applied in the next week.

Thank youuuu!

@kickscondor kickscondor merged commit f6e5102 into kickscondor:master May 3, 2021
@rafapaezbas rafapaezbas deleted the feature/link-target branch May 16, 2021 10:40
@magasine
Copy link

Being able to open links in new page is really very useful.
You could add a script on page load, something like:

javascript: var linksArr = document.getElementsByTagName("a");
for (i = 0; i < linksArr.length; i++) {
    linksArr[i].setAttribute("target", "_blank");
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants