Merged
Conversation
Owner
|
This is so cool! Thank you, Rafa. I'm sorry I haven't been around enough to inspect this. But it looks good and I hope to get this applied in the next week. Thank youuuu! |
|
Being able to open links in new page is really very useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am new to Open Source contributions and this is the first PR I do to a Open Source project, honestly its only kind of an experiment because I would like to learn how to contribute.
I have seen issue #203, and I thought I could give it a try. I am not familiar with Hyperapp architecture, but I have tried following the way settings work in the app.
This settings option is only visible for the web extension because for the App, the links are always open in a different window.
Thank you very much for your time and your work, that I think is really amazing!
Best regards,
Rafa