From 082cbc4b2c92684f3eb6f240612d3e0502ce3aa5 Mon Sep 17 00:00:00 2001 From: Izzy Oji Date: Thu, 16 Apr 2020 13:40:03 -0400 Subject: [PATCH] =?UTF-8?q?[=E2=84=B9=EF=B8=8F]=20NT-1143=20Adding=20more?= =?UTF-8?q?=20info=20to=20TrackingWorker=20error=20logs=20(#839)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Added the `response.message` and `runAttemptCount` to the error message that's logged when an event fails to track. ## build.gradle I had to add another repo for Apollo because it was causing the build to fail. --- .../main/java/com/kickstarter/services/TrackingWorker.kt | 6 +++--- build.gradle | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/kickstarter/services/TrackingWorker.kt b/app/src/main/java/com/kickstarter/services/TrackingWorker.kt index 0c1d46009b..a538c603bf 100644 --- a/app/src/main/java/com/kickstarter/services/TrackingWorker.kt +++ b/app/src/main/java/com/kickstarter/services/TrackingWorker.kt @@ -27,7 +27,7 @@ abstract class TrackingWorker(@ApplicationContext applicationContext: Context, p Result.success() } else { val code = response.code() - logTrackingError(code) + logTrackingError(code, response.message()) when (code) { in 400..499 -> { Result.failure() @@ -44,8 +44,8 @@ abstract class TrackingWorker(@ApplicationContext applicationContext: Context, p Crashlytics.log(this.eventName) } - private fun logTrackingError(code: Int) { - val errorMessage = "$code Failed to track $tag event: $eventName" + private fun logTrackingError(code: Int, message: String) { + val errorMessage = "$code Failed to track $tag event $eventName (run attempt #$runAttemptCount) $message" if (this.build.isDebug) { Timber.e(errorMessage) } diff --git a/build.gradle b/build.gradle index 893b28f2e8..32af8de930 100644 --- a/build.gradle +++ b/build.gradle @@ -17,6 +17,7 @@ buildscript { allprojects { repositories { google() + maven { url = uri("https://dl.bintray.com/apollographql/android/") } jcenter() mavenCentral() maven {