[馃泚] Adding new project properties #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented new project property values in TrackingClient. Updated Lake and Koala tests.
# Conflicts: # app/src/test/java/com/kickstarter/libs/LakeTest.kt
eoji
changed the title
ifbarrera
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
Updating "Project Properties" tracking group.
馃 Why
Another PR to get new events together.
馃洜 How
project.staticUsdRatenot optional.馃憖 See
N/A
馃搵 QA
All project events sent to the Lake 馃挧 should have these properties.
This is a WIP so I'm only hitting staging.
Story 馃摉
Part of NT-654
**Note: ** Tags are not returned in v1 so the value for
project_tagswill always benull.