From d954d24273b3df1956b35fda8af1f8d77b285a23 Mon Sep 17 00:00:00 2001 From: Scott Clampet <110618242+scottkicks@users.noreply.github.com> Date: Thu, 27 Oct 2022 09:30:15 -0400 Subject: [PATCH] NTV-612: Move Minimum Version Up To iOS 14 (#1751) * set minimum ios version to 14.0 * address deprecation warnings * feedback * formatting Co-authored-by: Scott Clampet Co-authored-by: Scott Clampet --- Kickstarter-iOS/AppDelegate.swift | 2 +- .../ThanksProjects/Controller/ThanksViewController.swift | 5 ++++- Kickstarter.xcodeproj/project.pbxproj | 8 ++++---- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/Kickstarter-iOS/AppDelegate.swift b/Kickstarter-iOS/AppDelegate.swift index 7e04c4ef00..4fc7443d85 100644 --- a/Kickstarter-iOS/AppDelegate.swift +++ b/Kickstarter-iOS/AppDelegate.swift @@ -496,7 +496,7 @@ extension AppDelegate: UNUserNotificationCenterDelegate { withCompletionHandler completionHandler: @escaping (UNNotificationPresentationOptions) -> Void ) { self.rootTabBarController?.didReceiveBadgeValue(notification.request.content.badge as? Int) - completionHandler(.alert) + completionHandler([.banner, .list]) } func userNotificationCenter( diff --git a/Kickstarter-iOS/Features/ThanksProjects/Controller/ThanksViewController.swift b/Kickstarter-iOS/Features/ThanksProjects/Controller/ThanksViewController.swift index a0d3299404..f2faaf44aa 100644 --- a/Kickstarter-iOS/Features/ThanksProjects/Controller/ThanksViewController.swift +++ b/Kickstarter-iOS/Features/ThanksProjects/Controller/ThanksViewController.swift @@ -220,7 +220,10 @@ internal final class ThanksViewController: UIViewController, UITableViewDelegate } fileprivate func showRatingAlert() { - SKStoreReviewController.requestReview() + if let scene = UIApplication.shared.connectedScenes + .first(where: { $0.activationState == .foregroundActive }) as? UIWindowScene { + SKStoreReviewController.requestReview(in: scene) + } } fileprivate func showGamesNewsletterAlert() { diff --git a/Kickstarter.xcodeproj/project.pbxproj b/Kickstarter.xcodeproj/project.pbxproj index 16d771e943..85492f11c2 100644 --- a/Kickstarter.xcodeproj/project.pbxproj +++ b/Kickstarter.xcodeproj/project.pbxproj @@ -9215,7 +9215,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 13.6; + IPHONEOS_DEPLOYMENT_TARGET = 14.0; MARKETING_VERSION = 5.5.0; MTL_ENABLE_DEBUG_INFO = NO; OTHER_LDFLAGS = "-ObjC"; @@ -9672,7 +9672,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 13.6; + IPHONEOS_DEPLOYMENT_TARGET = 14.0; MARKETING_VERSION = 5.5.0; MTL_ENABLE_DEBUG_INFO = YES; ONLY_ACTIVE_ARCH = YES; @@ -9741,7 +9741,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 13.6; + IPHONEOS_DEPLOYMENT_TARGET = 14.0; MARKETING_VERSION = 5.5.0; MTL_ENABLE_DEBUG_INFO = NO; OTHER_LDFLAGS = "-ObjC"; @@ -9995,7 +9995,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 13.6; + IPHONEOS_DEPLOYMENT_TARGET = 14.0; MARKETING_VERSION = 5.5.0; MTL_ENABLE_DEBUG_INFO = NO; OTHER_LDFLAGS = "-ObjC";