Profile updates #4
Conversation
| element?.layer.anchorPoint = CGPoint(x: CGFloat(anchorX), y: 0.5) | ||
| } | ||
| let scaleX = progress >= 1.0 ? 1.0 : progress | ||
| element?.transform = CGAffineTransformMakeScale(CGFloat(scaleX), 1.0) |
There was a problem hiding this comment.
there was some funkadelic stuff happening with the progress bar overlapping the space if progress was greater than 1.0, although we use this logic in every place we have a progress bar. I think this could be improved by a math whiz.
There was a problem hiding this comment.
you could do let scaleX = min(1.0, progress) or you could set some clipping properties on the enclosing view to prevent it from overlapping
| element?.layer.anchorPoint = CGPoint(x: CGFloat(anchorX), y: 0.5) | ||
| } | ||
| let scaleX = progress >= 1.0 ? 1.0 : progress | ||
| element?.transform = CGAffineTransformMakeScale(CGFloat(scaleX), 1.0) |
There was a problem hiding this comment.
you could do let scaleX = min(1.0, progress) or you could set some clipping properties on the enclosing view to prevent it from overlapping
| DiscoveryParams.defaults | ||
| |> DiscoveryParams.lens.backed .~ true | ||
| |> DiscoveryParams.lens.sort .~ .endingSoon | ||
| } |
There was a problem hiding this comment.
could mapConst this since it doesnt depend on the value emitted.
| |> UILabel.lens.font .~ .ksr_subhead(size: 12) | ||
|
|
||
| self.dividerView | ||
| |> UIView.lens.backgroundColor .~ .ksr_navy_400 |
There was a problem hiding this comment.
you can use separatorStyle for this
|
full suite passes locally. mergin! |
What is this?
Some Profile updates, namely: